1
Vote

Cleanup code - PlacesExport

description

The code underlying "Export places" in PlacesExport.cs has several issues and could be cleaned up.
  1. It would be more efficient to filter the peopleCollection for living/private once at the beginning, rather than repeat for each sub-task.
  2. The work performed for births, deaths, etc is extremely similar and should be refactored out to a common subroutine.
  3. The work performed for marriages and divorces are extremely similar and should be refactored out to a common subroutine.
  4. Split out the work for places/times/lifespans into separate subroutines.
  5. The class/method should be made static.

comments